-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable test for v1alpha2 #465
Conversation
/hold |
/hold cancle |
/hold cancel |
Thanks for your contribution! Let's wait for the CI result. |
component: workflows-v1alpha2 | ||
name: e2e-v1alpha2-release | ||
job_types: | ||
- postsubmit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need postsubmit for v1alpha2 if the same image is built ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In future, I wonder if all the images containing both versions (at least, metricsCollectors may be dropped). keep it as it is now, update it later if in need
manifests/v1alpha2/katib-controller/trialTemplateConfigmap.yaml
Outdated
Show resolved
Hide resolved
manifests/v1alpha2/katib-controller/trialTemplateConfigmap.yaml
Outdated
Show resolved
Hide resolved
/retest |
/lgtm |
Thanks, lgtm! |
Thanks for review |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is initial version to enable test for v1alpha2.
Now, for v1alpha2 test, only build katib-controller and test if the deployment Pod is running or not.
After other components done, add corresponding tests one by one.
@richardsliu @johnugeorge @YujiOshima @gaocegege Please help review it. thanks!
This change is